Skip to content

Conversation

@shnizzedy
Copy link
Member

Related to

Related to #2282 (comment) by @birajstha & @shnizzedy

Description

Refactors the autoversioning script to be a bit more robust.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the fix/check_s3 branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy requested a review from birajstha September 23, 2025 19:42
@shnizzedy shnizzedy requested review from a team as code owners September 23, 2025 19:42
@shnizzedy shnizzedy marked this pull request as draft September 23, 2025 19:44
@shnizzedy shnizzedy mentioned this pull request Sep 23, 2025
8 tasks
@shnizzedy shnizzedy marked this pull request as ready for review September 23, 2025 19:57
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.9%. Comparing base (c583008) to head (5a64fad).
⚠️ Report is 56 commits behind head on fix/check_s3.

Files with missing lines Patch % Lines
CPAC/info.py 80.0% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           fix/check_s3   #2288     +/-   ##
==============================================
+ Coverage          34.2%   34.9%   +0.6%     
==============================================
  Files               234     234             
  Lines             26379   26632    +253     
  Branches           4137    4184     +47     
==============================================
+ Hits               9033    9290    +257     
+ Misses            16615   16602     -13     
- Partials            731     740      +9     
Files with missing lines Coverage Δ
CPAC/pipeline/cpac_pipeline.py 45.8% <ø> (ø)
CPAC/info.py 85.5% <80.0%> (+1.5%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@birajstha birajstha merged commit 855e83a into fix/check_s3 Sep 25, 2025
27 checks passed
@shnizzedy shnizzedy deleted the fix-autoversioning branch September 25, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants